Skip to content

task(RHOAIENG-26481): Existing cluster RayJob demo notebook #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

chipspeak
Copy link
Contributor

Issue link

Jira

What changes have been made

New demo notebook which demonstrates the new RayJob submission against existing RayClusters.

Verification steps

  1. Build a version of the CodeFlare SDK from this branch.
  2. pip install this whl file in a local jupyter notebook.
  3. Run oc login using your OpenShift creds.
  4. Run through the notebook one cell at a time and verify via OpenShift pods etc

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2025
@chipspeak chipspeak marked this pull request as ready for review August 1, 2025 14:03
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2025
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.06%. Comparing base (e2fc98b) to head (2fc5701).
⚠️ Report is 3 commits behind head on ray-jobs-feature.

Additional details and impacted files
@@                Coverage Diff                @@
##           ray-jobs-feature     #875   +/-   ##
=================================================
  Coverage             93.06%   93.06%           
=================================================
  Files                    28       28           
  Lines                  1513     1513           
=================================================
  Hits                   1408     1408           
  Misses                  105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@kryanbeane kryanbeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, very easy to follow & very well written. Thanks Pat :)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2025
Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 2eee6e2 into project-codeflare:ray-jobs-feature Aug 13, 2025
10 checks passed
@kryanbeane kryanbeane deleted the RHOAIENG-26481 branch August 13, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants